-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: special characters in enum values #497
Conversation
Pull Request Test Coverage Report for Build 1416361083
💛 - Coveralls |
@panwauu you have one sonarcloud code smell :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, good job! 🎉
Do you want to create the follow-up issue, that enum: ['test+', 'test_plus']
causes clashes, as both will generate TEST_PLUS
name?
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
🎉 This PR is included in version 0.39.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
I added a Helper Function to resolve ascii characters that are not numbers or letters ([0-9a-zA-Z]) and translate them to english. - becomes minus, + becomes plus ...
The function also accepts characters to be ignored and a seperator string to seperate the translated characters from the rest.
Applied this function to the enum renderer to resolve the issue
Related issue(s)
Fixes #450
Tests
In #450 a blacklisted test is mentioned