Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add generate example preset for JS #629

Merged
merged 12 commits into from
Feb 15, 2022
Merged

feat: add generate example preset for JS #629

merged 12 commits into from
Feb 15, 2022

Conversation

Samridhi-98
Copy link
Collaborator

Description

  • Added example option in javascript/commonpreset.ts
  • Modified docs/language/javascript
  • Added test for example option

Related issue(s)

Fixes #625

@coveralls
Copy link

coveralls commented Feb 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1846912574

  • 35 of 38 (92.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 93.452%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/javascript/presets/utils/ExampleFunction.ts 32 35 91.43%
Totals Coverage Status
Change from base Build 1841756308: -0.05%
Covered Lines: 2525
Relevant Lines: 2576
💛 - Coveralls

@Samridhi-98 Samridhi-98 marked this pull request as draft February 11, 2022 06:09
@Samridhi-98 Samridhi-98 marked this pull request as ready for review February 13, 2022 05:30
@Samridhi-98
Copy link
Collaborator Author

@jonaslagoni please review my PR 🙂

jonaslagoni
jonaslagoni requested changes Feb 13, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind splitting this into two PR's? Cause if we ever have to rollback the example feature, we would need to rollback the marshalling example as well, which is not preferred 😄

@Samridhi-98
Copy link
Collaborator Author

Samridhi-98 commented Feb 13, 2022 •
edited
Loading

@jonaslagoni Sure, will do it 🙂

jonaslagoni
jonaslagoni requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, I had to review make sure I did not ask you to remove the example for the feature just to ask you to add it again 😆

Remember to create example as well as add the documentation for https://github.com/asyncapi/modelina/blob/master/docs/languages/JavaScript.md 🙂

@Samridhi-98 Samridhi-98 mentioned this pull request Feb 14, 2022
Merged
@Samridhi-98
Copy link
Collaborator Author

Hahaha, I had to review make sure I did not ask you to remove the example for the feature just to ask you to add it again 😆

Remember to create example as well as add the documentation for https://github.com/asyncapi/modelina/blob/master/docs/languages/JavaScript.md 🙂

Sorry, I misunderstood it.
I have opened another PR for examples 🙂

@jonaslagoni
Copy link
Member

Sorry, I misunderstood it. I have opened another PR for examples 🙂

You did not misunderstand anything 🙂 The example you have added in your PR, is the one about marshalling right?

In this PR, we need an example for the example preset you have added 🙂

@Samridhi-98
Copy link
Collaborator Author

Oh, yeah mistakenly I had added a marshaling example in this PR. 😅

jonaslagoni
jonaslagoni requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small change 💪

test/generators/javascript/preset/utils/ExampleFunctions.spec.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jonaslagoni
jonaslagoni approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jonaslagoni jonaslagoni changed the title feat: added example in js feat: add generate example preset for JS Feb 15, 2022
@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit c9980fc into asyncapi:master Feb 15, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: Update JavaScript.md with un/marshal function
4 participants
@Samridhi-98 @coveralls @jonaslagoni @asyncapi-bot