-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add javascript marshaling example #635
Conversation
@jonaslagoni please review 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to add the example to the list of examples in the readme 🙂
https://github.com/asyncapi/modelina/blob/master/examples/README.md
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Do you mind changing the title of the PR to docs
, as this is not a feature people can use, this is more towards the documentation and testing 🙂
Also maybe docs: add javascript marshaling example
is a more accurate title🤔 What do you think?
Pull Request Test Coverage Report for Build 1841515971
💛 - Coveralls |
Done 😊 |
🎉 This PR is included in version 0.49.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @Samridhi-98 for code, test, docs, example |
I've put up a pull request to add @Samridhi-98! 🎉 |
🎉 This PR is included in version 1.0.0-next.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
example/js-generate-marshalling
docs/language/javascript.md