Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add javascript marshaling example #635

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

Samridhi-98
Copy link
Collaborator

@Samridhi-98 Samridhi-98 commented Feb 14, 2022

Description

  • Added example/js-generate-marshalling
  • Modified docs/language/javascript.md

@Samridhi-98
Copy link
Collaborator Author

@jonaslagoni please review 😅

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add the example to the list of examples in the readme 🙂
https://github.com/asyncapi/modelina/blob/master/examples/README.md

@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Samridhi-98 Samridhi-98 changed the title feat: js example template feat: javascript marshalling template Feb 14, 2022
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Do you mind changing the title of the PR to docs, as this is not a feature people can use, this is more towards the documentation and testing 🙂

Also maybe docs: add javascript marshaling example is a more accurate title🤔 What do you think?

@coveralls
Copy link

coveralls commented Feb 14, 2022

Pull Request Test Coverage Report for Build 1841515971

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.5%

Totals Coverage Status
Change from base Build 1836792323: 0.05%
Covered Lines: 2490
Relevant Lines: 2538

💛 - Coveralls

@Samridhi-98 Samridhi-98 changed the title feat: javascript marshalling template docs: add javascript marshaling example Feb 14, 2022
@Samridhi-98
Copy link
Collaborator Author

LGTM 👍 Do you mind changing the title of the PR to docs, as this is not a feature people can use, this is more towards the documentation and testing 🙂

Also maybe docs: add javascript marshaling example is a more accurate title🤔 What do you think?

Done 😊

@jonaslagoni jonaslagoni merged commit 5567586 into asyncapi:master Feb 14, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni
Copy link
Member

@all-contributors please add @Samridhi-98 for code, test, docs, example

@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @Samridhi-98! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants