Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add champions concept #638

Merged
merged 18 commits into from
Feb 28, 2022
Merged

docs: add champions concept #638

merged 18 commits into from
Feb 28, 2022

Conversation

jonaslagoni
Copy link
Member

Description
This PR introduces the champion concept.

Related issue(s)
Related discussion: #487

@jonaslagoni jonaslagoni changed the title docs: introducing champions concept docs: add champions concept Feb 14, 2022
@jonaslagoni jonaslagoni marked this pull request as ready for review February 14, 2022 19:24
@coveralls
Copy link

coveralls commented Feb 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1910657268

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.431%
Totals Coverage Status
Change from base Build 1854331973: 0.0%
Covered Lines: 2526
Relevant Lines: 2577
💛 - Coveralls

jonaslagoni
jonaslagoni commented Feb 15, 2022
View reviewed changes
CODEOWNERS Outdated Show resolved Hide resolved
magicmatatjahu
magicmatatjahu requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in English but I gave some comments 😅 I like the idea and I am for it!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
docs/champions.md Outdated Show resolved Hide resolved
docs/champions.md Outdated Show resolved Hide resolved
@jonaslagoni
Copy link
Member Author

jonaslagoni commented Feb 17, 2022 •
edited
Loading

@alequetzalli if you have time I would love to hear your opinion on this 🙂

magicmatatjahu
magicmatatjahu previously approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Alejandra should look at this :)

quetzalliwrites
quetzalliwrites reviewed Feb 26, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
quetzalliwrites
quetzalliwrites previously approved these changes Feb 26, 2022
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had 1 suggestion ✨✨

@jonaslagoni @quetzalliwrites
Update README.md
1018e86 
Co-authored-by: Alejandra Quetzalli  <[email protected]>
magicmatatjahu
magicmatatjahu previously approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have only one comment, please refer to it before merge :)

README.md Outdated Show resolved Hide resolved
magicmatatjahu
magicmatatjahu reviewed Feb 28, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
magicmatatjahu
magicmatatjahu approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

/rtm

@jonaslagoni jonaslagoni merged commit a88d0bf into asyncapi:master Feb 28, 2022
@jonaslagoni jonaslagoni deleted the feature/champions branch February 28, 2022 14:22
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quetzalliwrites quetzalliwrites quetzalliwrites left review comments

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaslagoni @coveralls @asyncapi-bot @quetzalliwrites @magicmatatjahu