Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change severity for channel name validation rule #747

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix: change severity for channel name validation rule #747

merged 1 commit into from
Apr 18, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Apr 13, 2023

Description

Fixes #740.

Related issue(s)
#740

@smoya smoya mentioned this pull request Apr 13, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

derberg
derberg approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🍺

@smoya
Copy link
Member Author

smoya commented Apr 18, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 5f825f2 into asyncapi:next-major Apr 18, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoya @asyncapi-bot @derberg