-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add info and dependant models #485
Conversation
@smoya I know that it's feature, but I prefer to add @derberg Maybe you wanna add something how we should annotate PRs for |
Co-authored-by: Maciej Urbańczyk <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>
@magicmatatjahu sorry I didn't get it why it can't be released as release candidate? what react component has to do here? |
@derberg due to the fact that in react component the first dozen of PRs were not released because the component itself did not work. Each PR was a new component rewritten to make PR easier. It is the same here. So the first PRs on |
@magicmatatjahu oh, ok, now it makes sense. I did not review this PR so was not aware what is the status. I totally agree that every release should include "working code", same with prereleases, something that can actually be used and integrated |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rtm |
Description
This PR adds Info and the dependant models (Contact, License). It also allows to retrieve Info from the document root.
The models are based on the new Intent API (even though Info looks the same by now).
Pending things that can be out of this PR:
Related issue(s)
#482