Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add needed mixins #491

Merged
merged 2 commits into from
Mar 16, 2022
Merged

refactor: add needed mixins #491

merged 2 commits into from
Mar 16, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

  • add mixins for tags, description, bindings, externalDocs and specification extensions
  • add needed functionality to extend models by mixins
  • add unit tests for mixins and create helpers to check inheritance of mixins

Related issue(s)
Part of #481
Part of #482

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Mar 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Mar 15, 2022 •
edited
Loading

@jonaslagoni Thanks! However I added to the tags and bindings the bindings, bindings(protocol: name) etc. methods that we don't have in the parser-api spec. @smoya @jonaslagoni please check out this, because if everyone agree that new methods are better we should change parser-api. Also we should have in mind that tags and bindings could change in the next major version so probably we should have mixins only for particular major version. WDYT?

@smoya
Copy link
Member

smoya commented Mar 15, 2022

@magicmatatjahu I think the methods you added make totally sense.
Do not worry about updating parser-api right now. We are not keeping up with it during this development as we are designing and implementing at the same time in order to detect issues earlier. That means we will do a massive update into the parser-api API once we can validate the implementation makes sense.

smoya
smoya approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit f1989d6 into asyncapi:next-major Mar 16, 2022
@magicmatatjahu magicmatatjahu deleted the next/common-models branch March 16, 2022 09:49
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
@magicmatatjahu
refactor: add needed mixins (asyncapi#491)
5bd8e6e
derberg pushed a commit that referenced this pull request Oct 4, 2022
@magicmatatjahu @derberg
refactor: add needed mixins (#491)
8a32da7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@smoya smoya smoya approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magicmatatjahu @smoya @jonaslagoni @asyncapi-bot