Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add filters to some collections #592

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Sep 5, 2022

Description

This PR adds:

  • FilterBySend() method to Messages, Servers, Operations, Channels models.
  • FilterByReceive() method to Messages, Servers, Operations, Channels models.

All changes are done based on the Parser-API; last development in particular can be found in asyncapi/parser-api#71.

Related issue(s)
#401

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@smoya
Copy link
Member Author

smoya commented Sep 6, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 14458ef into asyncapi:next-major Sep 6, 2022
magicmatatjahu pushed a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants