Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #18

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Dec 9, 2021

Description

Add @smoya @jonaslagoni @BOLT04 and me as CODEOWNERS of this project:

  • @smoya because he is a expert in the backend and actively participated in the discussion about architecture of the API
  • @jonaslagoni like Sergio
  • @BOLT04 like Sergio and Jonas, but also contributed to other parts of our tools, so I think that it's a good person.
  • me because I started that project and wrote first path - chore: add /generator path #7

@BOLT04 If you think you don't want to be a part of this project let us know, even if we merge this PR and you don't respond. We can always add/remove you later, no rush :)

@jonaslagoni
Copy link
Member

jonaslagoni commented Dec 9, 2021

Appreciate the thought, however, unless it is required for some reason, I don't think it makes sense to add me as codeowner.

Especially if you have @smoya and @BOLT04 to join you 🙂

CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Sergio Moya <[email protected]>
@smoya
Copy link
Member

smoya commented Dec 9, 2021

@BOLT04 If you think you don't want to be a part of this project let us know, even if we merge this PR and you don't respond. We can always add/remove you later, no rush :)

I would not merge this PR if @BOLT04 does not approve it. I would wait for its response or rather remove it now and add it later if they wish.

@smoya smoya mentioned this pull request Dec 9, 2021
Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @magicmatatjahu, thank you so much for the opportunity and the tag 😃.
I'll do my best to contribute and collaborate with you all on this project (and on the whole community 😄)

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Dec 10, 2021

@BOLT04 Awesome to hear that! I don't know if you read my message to you on Slack, so I will paste it here because it is very important. If you still want be a maintainer, please agree or not :)

Hello! I opened PR with adding codeowners for server-api and also I added you. If you have objections, please write them in the PR's comment #18 Of course with benefits (like membership in the TSC - more info here https://github.com/asyncapi/community/blob/master/CHARTER.md) you will have also responsibilities. I chose you because you participated with several projects in our org like parser-js, server-api and also github-action, so I would like to have you as a maintaner in our project. Of course no rush, you don't have to agree, just let us know if you accept these conditions or not :)

@BOLT04
Copy link
Member

BOLT04 commented Dec 11, 2021

@magicmatatjahu thanks for the notice 👍, I've sent some questions to you on slack regarding timezones and voting 🙂

@magicmatatjahu magicmatatjahu merged commit 08575ae into asyncapi:master Dec 13, 2021
@magicmatatjahu magicmatatjahu deleted the add-codeowners branch December 13, 2021 13:01
@magicmatatjahu
Copy link
Member Author

@BOLT04 Hello! Could you add yourself as TSC Member like in this PR asyncapi/community#179 in community repo? Please add info about your company and add yourself to the server-api projekt as maintainer :) We can do it for you, but it will be better that you will do, ok? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants