Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct unsigned long handling #161

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Correct unsigned long handling #161

merged 1 commit into from
Dec 13, 2023

Conversation

mirromutth
Copy link
Contributor

Motivation:

Length-encoded integers should be handled correctly, especially those larger than Long.MAX_VALUE. See also #39.

Modification:

  • Add code comments to explain how to handle the length encoded integer.
  • Correct LargeFieldReader.readSlice() method, it should use the length as an unsigned long.

Result:

  • LargeFieldReader.readSlice() should now work correctly for fields those size is greater than 263-1

- Add code comments to explain how to handle the length encoded integer.
- Correct LargeFieldReader.readSlice() method, it should use the length as an unsigned long.
@jchrys jchrys self-requested a review December 13, 2023 07:57
@jchrys jchrys added this to the 1.0.6/0.9.7 milestone Dec 13, 2023
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jchrys
Copy link
Collaborator

jchrys commented Dec 13, 2023

Hello @mirromutth,

Would you be interested in rejoining the project? Your expertise is invaluable. If you find the time and inclination to participate once again, your insights and guidance would be highly appreciated.

Thank you for considering this, and I look forward to hearing from you.

@jchrys jchrys added bug Something isn't working enhancement New feature or request labels Dec 13, 2023
@mirromutth
Copy link
Contributor Author

Hello @mirromutth,

Would you be interested in rejoining the project? Your expertise is invaluable. If you find the time and inclination to participate once again, your insights and guidance would be highly appreciated.

Thank you for considering this, and I look forward to hearing from you.

Hello @jchrys,

Thank you for your kind words. I appreciate your message and the kind invitation to rejoin the project. Yes, I think I can do something to this project.

While I may not consider myself an expert, I am interested in making some contributions to the project.

Thank you for considering my participation, please let me know if there is anything I need to note.

Best Regards,

@jchrys
Copy link
Collaborator

jchrys commented Dec 13, 2023

Thanks for your reply! 🎉
I'm thrilled to have you back as an active.
I will be opening some issues that would require your valuable opinion.
Thanks a lot!

@jchrys jchrys merged commit 82a2a8a into asyncer-io:trunk Dec 13, 2023
10 checks passed
jchrys pushed a commit that referenced this pull request Dec 18, 2023
Motivation:

Length-encoded integers should be handled correctly, especially those
larger than `Long.MAX_VALUE`. See also #39.

Modification:

- Add code comments to explain how to handle the length encoded integer.
- Correct `LargeFieldReader.readSlice()` method, it should use the
length as an unsigned long.

Result:

- `LargeFieldReader.readSlice()` should now work correctly for fields
those size is greater than 2<sup>63</sup>-1
mirromutth added a commit that referenced this pull request Dec 19, 2023
Motivation:

Length-encoded integers should be handled correctly, especially those
larger than `Long.MAX_VALUE`. See also #39.

Modification:

- Add code comments to explain how to handle the length encoded integer.
- Correct `LargeFieldReader.readSlice()` method, it should use the
length as an unsigned long.

Result:

- `LargeFieldReader.readSlice()` should now work correctly for fields
those size is greater than 2<sup>63</sup>-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants