Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable createDatabaseIfNotExist #169

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Dec 18, 2023

Motivation:

See also #158 .

It should be named createDatabaseIfNotExist, the same as JDBC naming.

Modification:

  • Add option to enable createDatabaseIfNotExist
  • Support COM_INIT_DB and database can be initialized after handshake
  • Support sending CREATE DATABASE IF NOT EXISTS statement and retrying COM_INIT_DB after COM_INIT_DB fails for the first time

Result:

Support createDatabaseIfNotExist.

- Support `InitDbMessage`.
- Support `changeDatabase` in `MySqlConnection`.
- Add integration tests for that.
@jchrys jchrys added this to the 1.0.6/0.9.7 milestone Dec 18, 2023
Copy link
Contributor

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirromutth mirromutth merged commit 563729d into 0.9.x Dec 19, 2023
9 checks passed
@mirromutth mirromutth deleted the 0.9.x-createDatabaseIfNotExist branch December 19, 2023 10:09
@jchrys jchrys added the enhancement New feature or request label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants