Remove Synchronized Statements(Loom-friendly) #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this PR is merged, we can consider removing |
JohnNiang
reviewed
Dec 21, 2023
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionFactory.java
Outdated
Show resolved
Hide resolved
mirromutth
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Lock#lock() should be executed before the try statement.
How about moving
lock#lock()before try statement? See the example at here.
src/main/java/io/asyncer/r2dbc/mysql/cache/PrepareBoundedCache.java
Outdated
Show resolved
Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionFactory.java
Outdated
Show resolved
Hide resolved
Motivation: Synchronized statements tend to pin virtual threads to carrier threads. Modification: Replaced synchronized statements with ReentrantLock Result: Loom-friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Synchronized statements tend to pin virtual threads to carrier threads.
Modification:
Replaced synchronized statements with ReentrantLock
Result:
Loom-friendly