Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Transactional Methods for Improved Request Queue Handling #180

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Dec 21, 2023

Motivation:
The current Transaction Methods implementation lacks consideration for the request queue, resulting in potential undefined behavior and issues.

Modifications:
Transaction Methods properly respect the request queue.

Result:
Bug resolved.
Enhanced stability and reliability.

Motivation:
The current Transaction Methods implementation lacks consideration for the request queue, resulting in potential undefined behavior and issues.

Modifications:
Transaction Methods properly respect the request queue.

Result:
Bug resolved.
Enhanced stability and reliability.
@jchrys jchrys added the bug Something isn't working label Dec 21, 2023
@jchrys jchrys added this to the 1.0.6/0.9.7 milestone Dec 21, 2023
Motivation:
The current Transaction Methods implementation lacks consideration for the request queue, resulting in potential undefined behavior and issues.

Modifications:
Transaction Methods properly respect the request queue.

Result:
Bug resolved.
Enhanced stability and reliability.
@mirromutth
Copy link
Contributor

mirromutth commented Dec 22, 2023

Maybe we should check the state in RequestQueue instead, I created a ticket #183 for that.

I think we can merge this PR first for fix the bug, and consider how to improve state checking (including other states).

@jchrys jchrys merged commit 550f8c3 into 0.9.x Dec 22, 2023
10 checks passed
@jchrys jchrys deleted the 0.9.x-transaction-request-queue branch December 22, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants