Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove socketTimeout #223

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

See also #222

Modification:

Remove deprecated option socketTimeout.

Result:

The option socketTimeout is removed.

@mirromutth mirromutth added this to the 1.1.0/0.10.0 milestone Feb 7, 2024
@mirromutth mirromutth linked an issue Feb 7, 2024 that may be closed by this pull request
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys added the enhancement New feature or request label Feb 7, 2024
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirromutth mirromutth merged commit aa5e215 into trunk Feb 7, 2024
12 checks passed
@mirromutth mirromutth deleted the 222-question-how-about-removing-sockettimeout branch February 7, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] How about removing socketTimeout?
3 participants