Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct initialization of SSL tunnel tests #231

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

If the server uses caching_sha2_password, the first time a client connects to the server, the server will require a native SSL connection. So all the SSL tunnel tests should be run after the caching_sha2_password initialization.

Steps to reproduce:

  1. Restart a MySQL server 8.x, keep it authentication plugin as caching_sha2_password
  2. Run SslTunnelIntegrationTest first, failed
Errors:
  SslTunnelIntegrationTest.sslTunnelConnectionTest » R2dbcPermissionDenied Access denied for user 'root'@'172.18.0.1' (using password: YES)

See also https://github.com/asyncer-io/r2dbc-mysql/actions/runs/7880628673/job/21502952115 . It skipped MariaDbTextIntegrationTest and SslTunnelIntegrationTest was the first case run, so it failed

Modification:

Add an initialization of SslTunnelIntegrationTest, it ensures the server has cached root user.

Result:

SslTunnelIntegrationTest.sslTunnelConnectionTest will not fail due to ordering of tests

@mirromutth mirromutth added the bug Something isn't working label Feb 13, 2024
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@mirromutth mirromutth merged commit b0d00a0 into trunk Feb 13, 2024
12 checks passed
@mirromutth mirromutth deleted the fix/init-caching-sha2-password branch February 13, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants