Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct an unexpected fall through #238

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Feb 16, 2024

Motivation:

An unexpected fall through, which should have no impact. Because no packets start with 0xFE during the command phase, the byte size is greater than 1, and not be OK or EOF.

Modification:

Correct an unexpected fall through in ServerDecoder.

Result:

Corrected an unexpected fall through.

@mirromutth mirromutth added the bug Something isn't working label Feb 16, 2024
@mirromutth mirromutth added this to the 1.1.2 milestone Feb 16, 2024
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow Nice catch 👍

@mirromutth mirromutth merged commit 26aa227 into trunk Feb 16, 2024
14 checks passed
@mirromutth mirromutth deleted the fix/unexpected-fall-through branch February 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants