Revise RowMetaData#getColumnMetadata(String)
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchrys
added
need-more-info
Motivation: The current behavior does not align with the specification Modifications: implement the intended behavior as per the specification. Result: Correct behavior
jchrys
force-pushed
the
1x-column-alignment
branch
from
4fab3f6
to
b73a539
Compare
mirromutth
reviewed
Mar 7, 2024
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/MySqlRowDescriptorTest.java
Outdated
Show resolved
Hide resolved
mirromutth
approved these changes
Mar 7, 2024
Motivation: The current behavior does not align with the specification Modifications: implement the intended behavior as per the specification. Result: Correct behavior
jchrys
added a commit
that referenced
this pull request
Mar 27, 2024
Motivation: `MySqlNames` is removed by #257 but related bench is not removed properly. Modifications: Removed MySqlNames bench Result: Clean up
mirromutth
pushed a commit
that referenced
this pull request
Mar 28, 2024
Motivation: `MySqlNames` is removed by #257 but related bench is not removed properly. Modifications: Removed MySqlNames bench Result: Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current behavior does not align with the specification
Modifications:
implement the intended behavior as per the specification.
Result:
Correct behavior