Reduce retained references to ConnectionContext #260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A small refactoring of
ConnectionContext
usage.It is based on challenges #228 and #89. If a MySQL connection is reconnected or redirected, the
ConnectionContext
needs to be recreated. If we accidentally retain a reference toConnectionContext
outside theclient
package, it may cause some unexpected behavior.Of course, there are some counterexamples here, such as
MySqlDataRow
that needs to retain theCodecContext
in which it was responded to. Regardless of whether the connection changes, theCodecContext
should be always the context of the connection which was responding to this row, instead of the current connection.Modification:
Result:
Remove
ConnectionContext
reference that's retained outsideclient
package, except those required by codecs