Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle BIT(1) as Boolean by Default #286

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Aug 3, 2024

Motivation:
BIT(1) should be treated as Boolean.

Modification:
set Boolean.class as `BIT(1)'s default java type.

Result:
Ensures BIT(1) is handled as Boolean by default. like mysql-connector-j's implementation.
Resolves #277

Motivation:
BIT(1) should be treated as `Boolean`.

Modification:
set `Boolean.class` as the default java type for `BIT(1)`.

Result:
Ensures that `BIT(1)` is handled as `Boolean` by default, similar to the implementation in MySQL Connector/j.
Resolves #277
@jchrys jchrys added this to the 1.3.0 milestone Aug 3, 2024
@jchrys jchrys added the enhancement New feature or request label Aug 3, 2024
@jchrys jchrys requested a review from mirromutth August 3, 2024 13:42
@jchrys jchrys merged commit f56eaa8 into trunk Aug 4, 2024
28 checks passed
@jchrys jchrys deleted the bit1-boolean-by-default branch August 4, 2024 02:41
@jchrys
Copy link
Collaborator Author

jchrys commented Aug 5, 2024

NovaFox161 added a commit to DreamExposure/TicketBird-Discord-Bot that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] return a scalar value instead of a buffer for bit fields, such as Byte.
1 participant