Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events disappear as soon as the start time is passed #88

Open
yanneves opened this issue Apr 30, 2015 · 4 comments
Open

Events disappear as soon as the start time is passed #88

yanneves opened this issue Apr 30, 2015 · 4 comments
Assignees

Comments

@yanneves
Copy link
Member

More of a consideration, pushed some code direct since this was an issue at that very moment..

Events should probably appear (when the site is re-generated) for at least that day, which withstands as long as we don't have multiple events occurring on the same day. Currently, an event will expire as soon as the start-time is in the past, e.g. > 7.15pm.

Will reopen this issue to make sure it's definitely desirable.

@yanneves
Copy link
Member Author

Reopening for discussion.

@yanneves yanneves reopened this Apr 30, 2015
@larister
Copy link
Contributor

I'd agree on this @aaunel, thanks. Can you reopen the PR pls?

@yanneves
Copy link
Member Author

Already committed @larister, this caused the PlayCanvas talk to disappear when I fixed the typo "Grame" => "Game" in the title. Noticed there was a minor bug related to this where updated events could disappear in limbo.

See b6e16b3

@larister
Copy link
Contributor

Ah sure, thanks @aaunel

On 10 May 2015 at 10:04, aaunel [email protected] wrote:

Already committed @larister https://github.com/larister, this caused
the PlayCanvas talk to disappear when I fixed the typo "Grame" => "Game" in
the title. Noticed there was a minor bug related to this where updated
events could disappear in limbo.

See b6e16b3
b6e16b3


Reply to this email directly or view it on GitHub
#88 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants