hid_xpadneo, rumble: Optimize motor reprogramming #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakra
added
0 | type: enhancement
kakra
force-pushed
the
rumble-optimization
branch
from
e50ecab
to
6976839
Compare
Maybe-fixes: atar-axis#189 Signed-off-by: Kai Krakow <[email protected]>
kakra
force-pushed
the
rumble-optimization
branch
from
6976839
to
1fd8b4a
Compare
|
Code Climate has analyzed commit 1fd8b4a and detected 0 issues on this pull request. View more on Code Climate. |
|
@friesnadrink I'd be happy if you could also test this as it fiddles with the quirk flags within the rumble protocol. Testing plan: Run your favorite games and see (or rather feel) if all the rumble effects still work as expected. |
|
I tested this for a bit with two controllers. One controller still got disconnected sporadically, then it rumbled for some time. I did not capture logs this time. If you need more information please let me know and I will see what I can provide. |
|
So we could merge it: It did not have any negative consequences. No logs needed in this thread. |
kakra
added
1 | state: ready to merge
and removed
1 | state: testing solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe-fixes: #189
Signed-off-by: Kai Krakow [email protected]