Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for disabling chords #435

Closed
wants to merge 2 commits into from
Closed

Add configuration for disabling chords #435

wants to merge 2 commits into from

Conversation

BoukeHaarsma23
Copy link
Contributor

For use with steam, the button chord guide + A is mapped to the QAM. To not lose the profile switching behavior let the user configure this.

closes #419

kakra
kakra requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@kakra kakra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally like your idea. For post-v0.10 I'm planning to make these changes while the driver is running through a sysfs interface, and this PR would pave a good way for it.

hid-xpadneo/src/hid-xpadneo.c Outdated Show resolved Hide resolved
docs/CONFIGURATION.md Outdated Show resolved Hide resolved
docs/CONFIGURATION.md Outdated Show resolved Hide resolved
hid-xpadneo/src/hid-xpadneo.c Outdated Show resolved Hide resolved
docs/CONFIGURATION.md Outdated Show resolved Hide resolved
@kakra kakra added the 0 | type: enhancement New feature or request label Jul 18, 2023
@kakra kakra added this to the v0.10 milestone Jul 18, 2023
@BoukeHaarsma23
Add configuration for disabling chords
239ac11 
For use with steam, the button chord guide + A is mapped to the QAM. To not lose the profile switching behavior let the user configure this.
@BoukeHaarsma23
Copy link
Contributor Author

Thanks for the review, I have adjusted everything accordingly.

kakra
kakra requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@kakra kakra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good, I'll need to figure out how to fix the CI failing. I may need to merge your PR manually with some amends if you don't mind.

docs/CONFIGURATION.md Outdated Show resolved Hide resolved
hid-xpadneo/src/hid-xpadneo.c Show resolved Hide resolved
@BoukeHaarsma23
Copy link
Contributor Author

Looks almost good, I'll need to figure out how to fix the CI failing. I may need to merge your PR manually with some amends if you don't mind.

Sure thing! Thanks

@codeclimate
Copy link

codeclimate bot commented Jul 18, 2023

Code Climate has analyzed commit 943ae7b and detected 0 issues on this pull request.

View more on Code Climate.

kakra pushed a commit to kakra/xpadneo that referenced this pull request Feb 22, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
9a9d8dc 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Closes: atar-axis#435
kakra pushed a commit to kakra/xpadneo that referenced this pull request Feb 22, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
5cf852b 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra
kakra approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@kakra kakra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into patch queue. This needs re-testing with the CI.

kakra pushed a commit to kakra/xpadneo that referenced this pull request Feb 23, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
1d6effd 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
@kakra
Copy link
Collaborator

kakra commented Feb 23, 2024

@BoukeHaarsma23 I fixed the CI bug, there was a superfluous A in MODULE_PARAM_DESC where it really should be MODULE_PARM_DESC. No idea why my local compiler just accepted it (and yours probably did, too), the CI did not. It's fixed now and queued in my patch queue for testing. This PR will automatically close once I merged it.

kakra pushed a commit to kakra/xpadneo that referenced this pull request Feb 23, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
4103a52 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Feb 23, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
f701173 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Feb 23, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
530de15 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Feb 23, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
a8666ca 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Feb 23, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
12f4608 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Mar 4, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
9d0745c 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Mar 4, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
82b1d76 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Mar 4, 2024
@kakra @atar-axis
xpadneo, mouse: Implement mouse support
f9ffcf5 
Co-authored-by: Jacob Essex <[email protected]>
Co-authored-by: Florian Dollinger <[email protected]>
Closes: atar-axis#160
Closes: atar-axis#105
Closes: atar-axis#99
Fixes: atar-axis#333
See-also: atar-axis#419
See-also: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Mar 4, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
afd33fa 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Fixes: atar-axis#454
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Mar 4, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
f61508f 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Fixes: atar-axis#454
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Mar 4, 2024
@kakra @atar-axis
xpadneo, mouse: Implement mouse support
55715d0 
Co-authored-by: Jacob Essex <[email protected]>
Co-authored-by: Florian Dollinger <[email protected]>
Closes: atar-axis#160
Closes: atar-axis#105
Closes: atar-axis#99
Fixes: atar-axis#333
See-also: atar-axis#419
See-also: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
@anthr76
Copy link

anthr76 commented Apr 13, 2024

Will this get merged?

@kakra
Copy link
Collaborator

kakra commented Apr 14, 2024

Sorry, I completely forgot about this. I've put it into my local testing branch now to see if there are no side effects.

@kakra kakra closed this in 2f77207 Apr 22, 2024
kakra added a commit to kakra/xpadneo that referenced this pull request Apr 22, 2024
@kakra @atar-axis
xpadneo, mouse: Implement mouse support
89b24ac 
Co-authored-by: Jacob Essex <[email protected]>
Co-authored-by: Florian Dollinger <[email protected]>
Closes: atar-axis#160
Closes: atar-axis#105
Closes: atar-axis#99
Fixes: atar-axis#333
See-also: atar-axis#419
See-also: atar-axis#435
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/xpadneo that referenced this pull request Oct 31, 2024
@BoukeHaarsma23 @kakra
xpadneo, core: Add configuration for disabling Xbox logo shift-mode
78ee7a2 
For use with Steam, the `Guide`+`A` is mapped to the QAM. To not lose
the profile switching behavior, let the user configure this.

Co-authored-by: Kai Krakow <[email protected]>
Fixes: atar-axis#419
Closes: atar-axis#435
Fixes: atar-axis#454
Signed-off-by: Kai Krakow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakra kakra kakra approved these changes

Assignees
No one assigned
Labels
0 | type: enhancement New feature or request
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Disable profile switching to allow key combos
3 participants
@BoukeHaarsma23 @kakra @anthr76