Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms_simplify silently changing the name of the geometry column #70

Closed
boshek opened this issue Feb 17, 2018 · 1 comment · Fixed by #73
Closed

ms_simplify silently changing the name of the geometry column #70

boshek opened this issue Feb 17, 2018 · 1 comment · Fixed by #73
Labels
Milestone

Comments

@boshek
Copy link

boshek commented Feb 17, 2018

ms_simplify() appears to be silently changing the name of the geometry column from X to geometry. See this reprex (using bcmaps):

library(sf)
library(rmapshaper)
library(bcmaps)

simplified <- nr_regions() %>%
  ms_simplify()

attr(simplified, "sf_column")
[1] "geometry"
attr(nr_regions(), "sf_column")
[1] "SHAPE"

@ateucher ateucher added the bug label Feb 17, 2018
@ateucher ateucher added this to the 0.4.0 milestone Feb 17, 2018
@ateucher
Copy link
Owner

ateucher commented Feb 17, 2018

Thanks for the report! Should be a relatively easy fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants