Add snap interval #43
Conversation
|
Thanks @nikolai-b! I'll probably have time to review this in a week or so, but if you want to check into why the builds are failing that would be awesome. (#23) |
|
Cheers, will do |
Current coverage is 98.63% (diff: 88.88%)@@ master #43 diff @@
==========================================
Files 12 12
Lines 357 367 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 354 362 +8
- Misses 3 5 +2
Partials 0 0
|
|
Ok, updated. I removed |
| @@ -173,12 +189,13 @@ make_simplify_call <- function(keep, method, keep_shapes, no_repair, snap, explo | |||
| } | |||
|
|
|||
| if (explode) explode <- "-explode" else explode <- NULL | |||
| if (snap && !is.null(snap_interval)) snap_interval <- paste("snap-interval=", snap_interval) | |||
There was a problem hiding this comment.
This should be paste0 instead of paste, but I'll make the fix after I merge it
There was a problem hiding this comment.
Eeek, of course, thanks for spotting.
|
Sorry for taking so long to get to this @nikolai-b - it looks good! There's one small fix that needs to be made, (see inline comments), but I'll do it after I merge. Then I'll add a few tests. Thanks so much for the contribution! As for the dropping null geometries, I went in a circles a bit on that, so I'm not overly surprised it's inconsistent. I'll have a look - would you mind opening a separate issue to remind me? |
Also looks like
drop_null_geometrieswasn't being pass through forgeo_listso I've added that in this PR.