Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to ensure tibble-in, tibble-out
Created on 2019-11-06 by the reprex package (v0.3.0)
I'm motivated by this because I rely on the behaviour of tibble in several places, I don't think it can cause problems - the test for it's a tibble is very specific (could be made more general in future if needed).
The only difference is the class attribute, as in if you compare
sf::st_as_sf(tibble::as_tibble(rmapshapher::ms_simplify(x)))
with current behaviour, you get an identical object with this PR.