Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An easier setup like starship #28

Merged
merged 10 commits into from
Mar 11, 2020
Merged

An easier setup like starship #28

merged 10 commits into from
Mar 11, 2020

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Mar 11, 2020

  • Setting up is now easy as eval "$(shelby init bash)".

  • Can work standalone using shelby info command

Tested in bash, not zsh

@ssiyad
Copy link
Contributor Author

ssiyad commented Mar 11, 2020

Solves rest of #20 I guess

@athul
Copy link
Owner

athul commented Mar 11, 2020

Thanks Bruh

Seems like zsh isn't working. Lemme try

@ssiyad
Copy link
Contributor Author

ssiyad commented Mar 11, 2020

@athul Fixed zsh

@athul
Copy link
Owner

athul commented Mar 11, 2020

Lol, I had made a PR to fix the zsh stuff

@athul
Copy link
Owner

athul commented Mar 11, 2020

ssiyad#1 This one

@ssiyad
Copy link
Contributor Author

ssiyad commented Mar 11, 2020

OOH! Didn't notice that. Is there any functional difference between the two? If yes, we could choose the better one

This File Doesn't do anything, the loader script for zsh is loaded from shell.go file
Same as zsh
Copy link
Owner

@athul athul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't so much need for precmd and we could use zsh setopt PROMPT_SUBST to sustitute that

mods/shell.go Outdated Show resolved Hide resolved
Copy link
Owner

@athul athul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athul athul merged commit 32685aa into athul:master Mar 11, 2020
athul added a commit that referenced this pull request Mar 11, 2020
* Cli in the Making

* Trying to get it working

* Updates on Looking at StarShip

* Error returns

* Optimize

* Fix zsh not picking up

* Delete init.zsh

This File Doesn't do anything, the loader script for zsh is loaded from shell.go file

* Delete init.bash

Same as zsh

* Lesser code execution,better loading time

Co-Authored-By: Athul Cyriac Ajay <[email protected]>

Co-authored-by: athul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants