Add dynamic recognition of sheet data entries and layout #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
atiratree
commented
Jun 2, 2022
•
atiratree
commented
- recognition done by DEFAULT_STRATEGY, WEEKEND_HEADER_ONLY_STRATEGY or LAST_SPACE_BETWEEN_ROWS_STRATEGY. LEGACY_STRATEGY is used only for tests.
- introduce ConsistencyChecker script for running data validation tasks and comparing output between strategies
- allow setting custom number of rows per group
- add unit tests for sheet detection logic
atiratree
force-pushed
the
updates
branch
2 times, most recently
from
42892e4
to
7cbe5c0
Compare
- display number of rows per group in groups list
- extracts layout, data and notes from sheets - replace copyDataBetweenSheets with extractSpreadsheetData and writeDataToSheet (eg in EmailSender) - update SheetRedirect functions (onOpenSheet, editMainSheet) to use extractSpreadsheetData and upgrade validations
- refactoring (mainly createStats and writeStats) - fix bug in OnOpen and OnEdit functions
… tests - WEEKEND_HEADER_ONLY_STRATEGY LAST_SPACE_BETWEEN_ROWS_STRATEGY - make isMetadataRow_ a little bit more strict - add new tests to SSExtract
- to test and compare behaviours between strategies to ensure there is no regression - add tests for extractSpreadsheetDataWithStrategy - enhance tests for detectDaysWithData_
introduced by a new implementation of extractSpreadsheetData
- add compareGatheredDataByStrategies which checks consistency of gathered data between new DEFAULT_STRATEGY vs LEGACY_STRATEGY and prints out a diff
change regression definition in compareGatheredDataByStrategies
atiratree
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.