-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align release workflow 2.4.0 #73
Conversation
phpstan.neon.dist
Outdated
# TODO these rules are generated, this ignores should be fixed in the code | ||
# level 0 | ||
- | ||
message: "#^Class Atk4\\\\Ui\\\\Persistence\\\\UI not found\\.$#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these errors must be definitely fixed
I can then look at the at burn and lowest test.
@abbadon1334 Any chance you could finalize this PR and make it compatible with ATK 3.0 ? |
sure @DarkSide666, what you think if, we release this for 2.4.0 ( see you what you do with failing new tests), and after that work on release for 3.0. I hope I don't have the same issues with the tests in 3.0 |
That sounds like a plan. |
…date-release-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.