Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Normalize Unit Testing workflow across repos #53

Merged
merged 21 commits into from
Apr 28, 2020
Merged

Normalize Unit Testing workflow across repos #53

merged 21 commits into from
Apr 28, 2020

Conversation

mvorisek
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 23, 2020 •
edited
Loading

Codecov Report

Merging #53 into develop will not change coverage.
The diff coverage is 48.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #53   +/-   ##
==========================================
  Coverage      61.87%   61.87%           
  Complexity       157      157           
==========================================
  Files              6        6           
  Lines            362      362           
==========================================
  Hits             224      224           
  Misses           138      138
Impacted Files Coverage Δ Complexity Δ
src/Migration/PgSQL.php 0.00% <0.00%> (ø) 10.00 <0.00> (ø)
src/Migration/SQLite.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/MigratorConsole.php 0.00% <ø> (ø) 4.00 <0.00> (ø)
src/Migration.php 62.55% <40.00%> (ø) 105.00 <0.00> (ø)
src/Migration/MySQL.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/PhpunitTestCase.php 84.28% <100.00%> (ø) 29.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb7b82...8cd2cd7. Read the comment docs.

@mvorisek mvorisek force-pushed the improve_unit_workflow branch 3 times, most recently from ca0b313 to 11363b5 Compare April 23, 2020 19:29
@mvorisek mvorisek marked this pull request as draft April 23, 2020 19:30
@mvorisek mvorisek force-pushed the improve_unit_workflow branch 2 times, most recently from 9604078 to 16e9b6a Compare April 24, 2020 08:50
@mvorisek mvorisek marked this pull request as ready for review April 24, 2020 08:56
@mvorisek mvorisek marked this pull request as draft April 25, 2020 23:31
@mvorisek mvorisek force-pushed the improve_unit_workflow branch 8 times, most recently from 4a3615f to c5c1656 Compare April 28, 2020 00:16
@mvorisek mvorisek marked this pull request as ready for review April 28, 2020 00:16
@mvorisek mvorisek force-pushed the improve_unit_workflow branch 2 times, most recently from 5948c21 to 8494f7d Compare April 28, 2020 10:22
DarkSide666
DarkSide666 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just few places where I think you can also move param types into model definition.

src/Migration.php Show resolved Hide resolved
src/Migration.php Show resolved Hide resolved
src/Migration.php Show resolved Hide resolved
src/Migration.php Show resolved Hide resolved
src/Migration.php Show resolved Hide resolved
src/Migration/SQLite.php Show resolved Hide resolved
@DarkSide666 DarkSide666 merged commit ec9ed1e into develop Apr 28, 2020
@DarkSide666 DarkSide666 deleted the improve_unit_workflow branch April 28, 2020 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666