This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Fix UNSIGNED integer key for PostgreSQL #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_postresql
branch
from
ed58035
to
b12a6b3
Compare
mvorisek
force-pushed
the
fix_postresql
branch
from
b12a6b3
to
a561178
Compare
mvorisek
force-pushed
the
fix_postresql
branch
from
a561178
to
1b5b884
Compare
georgehristov
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
I would really like to see proper use of OOP in such cases (having specific routine in the specific class and not checking the object type) but this is okay as quickfix
In this case we should maybe add call to $this->getSqlFieldInteger($options) and skip adding 'unsigned' in Migration\Postresql::getSqlFieldInteger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/20810134/why-unsigned-integer-is-not-available-in-postgresql