Add ability to read file object #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function read_file_object has been added in order to be able to directly read a file object (useful for many usecases)
|
This PR is based on [https://github.com//pull/331](this one) as it's the same use case. I added a test and modified the code in a simpler way (and following PEP8 guidelines). I've read your previous comment about the |
|
just realizing this is a somewhat old? repository? @simonghrt if you read this, resend the pull request over here: |
|
It would be really nice to get this functionality in camelot. @simonghrt Can you create a new PR for the camelot-dev repo? |
|
We'd also love this over using tempfile! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function read_file_object has been added in order to be able to
directly read a file object (useful for many usecases)