Return an error instead of nil when parseline gets nil/empty input #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -188,10 +189,15 @@ func (mr *metricReceiver) getAdditionalTags(addr string) types.Tags { | |||
|
|
|||
| // ParseLine with lexer impl. | |||
| func (mr *metricReceiver) parseLine(line []byte) (*types.Metric, error) { | |||
| if line == nil { | |||
| return nil, errors.New("Error parsing line. Byte array is nil") | |||
| } | |||
There was a problem hiding this comment.
I don't think this check is necessary, is it?
|
Thanks for doing this! Can you share the input data corpus you used? Tooling/code you wrote? I'd like to include it in the build process. |
|
I have a WIP fuzz branch that includes a few items in the corpus as well as a new 'fuzz' target in the Makefile. Regarding the above questions about defensive checking, you will see if you look at that branch that there is code that does round-tripping using a call to parseLine. Without those checks, go-fuzz reports a crasher. |
|
I've merged my branch where this piece is refactored. Thanks for the effort! I'll take a look at your branch when I have time. Really keen to add fuzz testing to this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of my first pass at go-fuzz'ing the lexer