support transformed draggables without portals #421
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #192 it looks like portals are not the way to go.
I agree. I usually love portals, but when performance is critical, they aren't great.
I have a hard requirement on using a transform.
We could do this without extending the API, but that would be more expensive because we'd have to climb the DOM tree looking for a
transform
. In the spirit of performance-first, I opted to add a single extraprovided
function. For those that don't use transforms, no change is required. For those that do, they add a single argument to a div.How it works:
react-beautiful-dnd uses
position: fixed
, which is great, except for 1 caveat. Per MDN docs:If the developer provides a
transformRef
, then that tells theDraggable
that an ancestor is being transformed, and therefore theleft, top
should be relative to the transformed node, not the viewport. It adjusts theleft, top
accordingly.