using recommended packages to avoid deprecation warnings #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
force-pushed
the
using-correct-imports
branch
from
f472ce7
to
67d92a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in anticipation of #8
This removes all the yuck deprecation warnings in the tests and development environments.
It also opens the way to React 16! I bumped to React 16 and everything looks good! I will not to React 16 until it is stable - but it good to know we are ready to go
(how I checked react 16: facebook/react#10294)
It was not a super in depth analysis - but it looks good on initial pass.
Some of the tests break moving to React 16 - but it looks like jest was throwing and error because the enzyme React dependency was not met correct - which makes sense.