WIP: Replace bundled Node with electron in ELECTRON_RUN_AS_NODE mode

This will allow us to require files from asar bundles and will avoid the need to vendor node.
atom · Jul 25, 2016 · 230a25f · 230a25f
1 parent f0bd2a4
commit 230a25f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,4 @@
 /node_modules/
-/bin/node*
 /lib/
 .DS_Store
 npm-debug.log

diff --git a/.npmignore b/.npmignore
@@ -4,6 +4,5 @@
 npm-debug.log
 spec/
 tasks/
-bin/node
 .travis.yml
 .pairs
diff --git a/bin/node b/bin/node
@@ -0,0 +1,4 @@
+ELECTRON_RUN_AS_NODE=1 "/Applications/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper" $@
+
+# TODO: Make this run Electron as node on the various platforms
+# What if there is no Atom yet? How do we find the downloaded electron? The answer may be just a hard-coded environment variable