This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix incorrect interpretation of ctrl-backspace when numlock is enabled on Windows #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when numlock is enabled, ctrl-backspace causes the
KeyboardEvent.key
property to beDelete
. This PR ensures we always interpret the physical backspace key asbackspace
for the purpose of matching key bindings.Refs atom/atom#12980