This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atom/maintainers I thought I'd make you aware of this API since it may be useful to suggest to users experiencing weird edge cases with keystroke resolution. I plan to hotfix it to
1.12-releases
to ensure there's a fallback strategy for any remaining keyboard layout issues we may have missed with the internationalization improvements.Rationale
There are quite a few Chrome bugs related to keyboard events on Linux. In addition, user expectations sometimes differ from our default behavior with respect to how we should interpret modifier keys on international keyboards. Finally, there are special modifier keys and crazy layouts on Linux that we don't have time to support right now.
Keystroke resolvers
The solution to all these problems and more is to allow users or packages to insert custom logic for resolving certain keyboard events to keystroke strings. When this PR lands, you'll be able to do something like the following.
See the API documentation for more details.