This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Always return an empty array in TokenizedBuffer.getInvalidatedRanges #12745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..because TokenizedBuffer never synchronously invalidates beyond the extent of the spatial change. Signed-off-by: Nathan Sobo <[email protected]>
6 tasks
as-cii
pushed a commit
that referenced
this pull request
Sep 22, 2016
Always return an empty array in TokenizedBuffer.getInvalidatedRanges
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were always mistakenly returning
[(0, 0), (0, 0)], thus causing the first line of a file to be constantly invalidated. This caused also a performance regression for long lines with lots of highlight decorations at row 0, because any change in the buffer at other rows caused that line to be re-rendered and, therefore, re-measured as well. This was a contributing factor in the performance problem mentioned on #12662.Since
TokenizedBuffernever synchronously invalidates beyond the extent of the spatial change we can simply return an empty array instead.