This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Use N-API prebuilds #106
Merged
Use N-API prebuilds #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For those interested, I uploaded a test build of GitHub Desktop that includes fs-admin with the changes from this PR (which also include #105), and it works fine! Download: https://s3.amazonaws.com/github-desktop/releases/2.7.3-test4-0e14ef24/GitHubDesktop-arm64.zip |
This was referenced Sep 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #105 and was inspired by atom/node-keytar#331
I still have to test it properly, I'll update this when I have more to share 😄Tested on https://github.com/desktop/desktop and works perfectly!