Merge pull request #131 from m-lnrs/suggestion-type-enum-issue-130

Fix auto import for enums
atom · Mar 4, 2021 · dede888 · dede888
2 parents c0379ef + 8167ff7
commit dede888
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/providers/autoImportActionProvider.js b/lib/providers/autoImportActionProvider.js
@@ -118,6 +118,7 @@ function getImportChoice(missingType, editor, typeRange, languageClient) {
 function buildImportSuggestion(autocompleteSuggestion) {
   switch (autocompleteSuggestion.type) {
   case 'class':
+  case 'enum':
     const { displayText } = autocompleteSuggestion
     const [ typeName, pkgName ] = displayText.split('-').map(s => s.trim())
 

diff --git a/test/autoImportActionProvider.test.js b/test/autoImportActionProvider.test.js
@@ -78,6 +78,25 @@ describe.only('autoImportActionProvider', () => {
       })
     })
 
+    describe('Suggestion Type: `enum`', () => {
+      it('should build the correct import package path', () => {
+        const suggestion = {
+          type: 'enum',
+          displayText: 'Month - java.time'
+        }
+
+        expect(buildImportSuggestion(suggestion)).to.equal('java.time.Month')
+      })
+
+      it('should throw error if type or package name is missing', () => {
+        try {
+          expect.fail('Should have thrown error')
+        } catch (error) {
+          expect(error).not.to.be.null
+        }
+      })
+    })
+
     it('should throw error for unknown suggestion type', () => {
       try {
         buildImportSuggestion({ type: 'unknown type' })