Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add support for vendor-prefixed values #80

Merged
merged 5 commits into from
Aug 28, 2016
Merged

Add support for vendor-prefixed values #80

merged 5 commits into from
Aug 28, 2016

Conversation

hediyi
Copy link
Contributor

@hediyi hediyi commented Aug 26, 2016

They're rare but they actually exist (see the specs for some examples), can't say there won't be more, hence the PR 😉

@winstliu
Copy link
Contributor

Why weren't the (xx) ones moved to be reverse-alphabetical?

@hediyi
Copy link
Contributor Author

hediyi commented Aug 26, 2016

Coz I sorted them with something like

s.split('|').sort { |a, b| b <=> a }.join('|')

and the first char ( is "smaller" than letters, so they ended up at the end.

The main reason I expanded the nested alternations is to get rid of the |s in them so they don't get in the way of the script above (which can be used every time you add new values). (xx?-)?small doesn't contain a | and I got lazy 😆

That a problem?

@winstliu winstliu merged commit 4de71e2 into atom:master Aug 28, 2016
@hediyi hediyi deleted the vendor-prefixed-value-support branch August 29, 2016 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants