Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Added support for type grouping when initializing or when calling make #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roeest
Copy link

@roeest roeest commented Dec 2, 2015

No description provided.

'match': '(?<=make\\()([^,\\)]*)'
'captures':
'1':
'patterns': [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified to just

'1':
  'include': '#types'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It stops working when i do that

@svanharmelen
Copy link
Contributor

I see the thing you're trying to solve, but I think it could be solved in a much cleaner way...

You should have a look at how this is solved with multiline variable declarations which are essentially the same thing, but then for variables instead of types.

Especially have a look at the use of 'include': '$self' which helps to prevent duplication code.

@roeest
Copy link
Author

roeest commented Dec 3, 2015

@svanharmelen - I looked at the variable declaration section, im not sure i understand how the $self syntax is helpful for what i'm trying to achieve here

@joefitzgerald
Copy link
Contributor

@svanharmelen is there a path forward on this PR?

@svanharmelen
Copy link
Contributor

@joefitzgerald I'm sorry, but I have to admit that I switched back to vim about 10 months ago. So I don't think I'm still the right person to judge this PR...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants