Improve entity scopes and related spec

[DavidePastore]

Related to atom/autocomplete-html#14

[winstliu]

Parentheses aren't required around this: you can just match the 0th capture instead.

[DavidePastore]

Hi @50Wliu and thanks for the suggestions. How do you think it should be? I don't know if I understand what you say.

[MaximSokolov]

'end': ';'
'endCaptures':
  '0':

[DavidePastore]

Thanks @MaximSokolov. Fixed in the last commit.

[winstliu]

What does this fix/add? Is there a reason we can't keep the existing match?

[DavidePastore]

@50Wliu The existing match doesn't give us the ability to understand if the user is inserting a new entity or the position of the cursor is on the last character (;).
This PR try to add captures that will be used in the autocomplete-html package (atom/autocomplete-html#19) so it can trigger the autocomplete of the HTML entities.

[revelt]

I'm investigating what's the latest on this PR, as I want to contribute few attributes to be suggested (they're not present in your pull btw) and these commits might overlap with what I want to add.

Half year has passed since latest action!

[winstliu]

It looks like I dropped the ball on this PR. At this point it needs to be rebased. I still am not convinced that we need to switch to a begin/end model as a capture can simply be added for the semicolon.

[DavidePastore]

@revelt If you want you can send me a PR to add more entities.
@50Wliu I'm all ears. What do you think we can do to proceed with this PR?

[winstliu]

Ok, here's what I'm proposing:

'captures':
  '1':
    'name': 'punctuation.definition.entity.html'
  '2':
    'name': 'entity.name.entity.other.html'
  '3':
    'name': 'punctuation.terminator.statement.html' # or something else, iunno
'match': '(&)([a-zA-Z0-9]+|#[0-9]+|#x[0-9a-fA-F]+)(;)'
'name': 'constant.character.entity.html'

Does that work out for what autocomplete-html needs?

[DavidePastore]

Thanks for your proposal @50Wliu . The issue with your solution is that your match doesn't find out if you're in the middle position of the entity (i.e. "&a"). I think that (;)' should be optional. What do you think?

[winstliu]

Ok, I see what you're saying now. Your solution looks like the way to go then.

[DavidePastore]

@50Wliu What is the next step? Should I rebase?

[winstliu]

Yes please.

[DavidePastore]

@50Wliu Rebase done. 🍨

[winstliu]

Thanks, and sorry for the delay!

[DavidePastore]

Thanks for merging 😸