Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix test failures #57

Closed
wants to merge 2 commits into from
Closed

Conversation

sadikovi
Copy link
Contributor

@sadikovi sadikovi commented Jun 13, 2016

It seems like master branch tests are broken:

[751:0613/174256:INFO:CONSOLE(52)] "Window load time: 503ms", source: file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js (52)
................FF

Java grammar
  it tokenizes try-catch-finally blocks
    Expected { value : 'variable', scopes : [ 'source.java', 'meta.class.java', 'meta.class.body.java', 
      'meta.method.java', 'meta.method.body.java', 'meta.catch.java', 'meta.catch.body.java', 
      'meta.definition.variable.java', 'variable.definition.java' ] 
    } to equal { value : 'variable', scopes : [ 'source.java', 'meta.class.java', 'meta.class.body.java', 
      'meta.method.java', 'meta.method.body.java', 'meta.catch.java', 'meta.catch.body.java', 
      'meta.definition.variable.java', 'variable.other.definition.java' ] }. (../../language-java/spec/java-spec.coffee:546:25)
  it tokenizes nested try-catch-finally blocks
    Expected { value : 'nested', scopes : [ 'source.java', 'meta.class.java', 'meta.class.body.java', 
      'meta.method.java', 'meta.method.body.java', 'meta.try.java', 'meta.try.body.java', 'meta.try.java', 
      'meta.try.body.java', 'meta.definition.variable.java', 'variable.definition.java' ] 
    } to equal { value : 'nested', scopes : [ 'source.java', 'meta.class.java', 'meta.class.body.java', 
      'meta.method.java', 'meta.method.body.java', 'meta.try.java', 'meta.try.body.java', 'meta.try.java', 
      'meta.try.body.java', 'meta.definition.variable.java', 'variable.other.definition.java' ] }. (../../language-java/spec/java-spec.coffee:592:25)


Finished in 0.58 seconds
18 tests, 291 assertions, 2 failures, 0 skipped

Tests failed

This PR fixes this by changing variable.other.definition.java to variable.definition.java.

@sadikovi
Copy link
Contributor Author

@50Wliu Can you have a look? Are you working on it already? If yes, I can close this PR.

@noseglid
Copy link
Contributor

The errors arose from here: #56
It should really be variable.other.definition.java, but that was part of above PR which was reverted. We're working on that.

@sadikovi
Copy link
Contributor Author

Okay, I am closing this PR then.

@sadikovi sadikovi closed this Jun 13, 2016
@sadikovi sadikovi deleted the fix-test-failures branch January 20, 2018 01:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants