Install fails under io.js 3.0.0

[limulus]

It appears that, in order to be compatible with io.js v3, it is necessary to update to nan v2.

I cloned the repo, updated the dependency, but it appears that the breaking changes that come along with nan v2 affect keytar, so that failed.

I'm not sure why the nan dependency is a static link to atom.io and not a semver range for downloading from an npm repository. Switching to a more standard ^2.0.0 range would probably be helpful to get more timely support for new versions of Node. (Though it obviously won't help in the case of a breaking change like this one.)

Thanks for this module! It’s a really slick cross-platform abstraction!

[kevinsawicki]

I'm not sure why the nan dependency is a static link to atom.io and not a semver range for downloading from an npm repository.

This is because this module was used by Atom and a custom nan version was needed during a Chromium/io.js upgrade Atom was going through.

[ariporad]

@kevinsawicki: Hi, I didn't really understand your comment, but do you know if/when this module will be compatable with iojs 3.0.0?

[kevinsawicki]

but do you know if/when this module will be compatable with iojs 3.0.0?

I don't know when. I haven't looked into what nan changes are required to get it working again on iojs 3.0.0.

[ariporad]

Ok, Thanks.

Ari

On Wed, Aug 26, 2015 at 3:56 PM, Kevin Sawicki [email protected]
wrote:

but do you know if/when this module will be compatable with iojs 3.0.0?

I don't know when. I haven't looked into what nan changes are required to
get it working again on iojs 3.0.0.

—
Reply to this email directly or view it on GitHub
#28 (comment).

[ffaubry]

+1 for a fix

[vijayendranj]

+1 for a fix

[ghost]

+1 Need this

[ChALkeR]

Adding to the list: nodejs/node#2798.

[limulus]

3.0.0 is working well for me on Node 4.0.0 (and Node 0.12.7 for that matter). Thank you all! 💯

[ffaubry]

Thanks guys. Just pulled Electron 0.32.1 and keytar. And the magic is back.

[vijayendranj]

Thx