Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Not able to set a modul tab length to default if main settings are different #774

Closed
henri-hulski opened this issue Apr 21, 2016 · 10 comments · Fixed by #967
Closed

Not able to set a modul tab length to default if main settings are different #774

henri-hulski opened this issue Apr 21, 2016 · 10 comments · Fixed by #967
Labels

Comments

@henri-hulski
Copy link

Description

I'm not able to set the tab length to the default value (2) in a language modul if I set a value in the main settings tab length,
It immediately changes to the tab length from the main settings.

See issue atom/atom#11546.
And also issues Lukasa/language-restructuredtext#37 and atom/language-gfm#134.

Steps to Reproduce

  1. Set tab length in main settings to 4.
  2. Go to the settings of language-html package and set the tab length to 2.
  3. It immediately changes to 4.
  4. When you leave it empty it shows Default: 2. But then also changes to 4.

It should possible to change the value to the default 2.
Now you can change it to every other value (1,3,5,etc) but not to 2.

Versions

Atom 1.7.2 and 1.8.0-beta2

@lee-dohm
Copy link
Contributor

Thanks very much! I reproduced this using Atom v1.7.2 on Mac OS X 10.11.4.

@leohacker
Copy link

Have the same issue. Why not use 4 as the default value for editor ?

@itaisod
Copy link

itaisod commented Jul 7, 2016

Confirmed with Atom 1.8.0, on Windows 10 64bit.
Note that in python, where the default tab length is 4 and not 2, the behavior is different.

@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Sep 12, 2016

Wow, sorry for this terrible experience everyone. Fixing now.

maxbrunsfeld added a commit to atom/atom that referenced this issue Sep 12, 2016
For scoped editor settings fix: atom/settings-view#774
@maxbrunsfeld
Copy link
Contributor

This fix will be released in Atom 1.12.

@sangdth
Copy link

sangdth commented Aug 18, 2017

I still meet this problem in Atom 1.19. And have to work around by using this gandm/language-babel#191

@lee-dohm
Copy link
Contributor

@sangdth I just tried to reproduce the issue listed above using Atom v1.19.2 on Mac OS X 10.12.6 and could not. If you are experiencing a reproducible problem, please open a new issue.

@AdrianChirila
Copy link

AdrianChirila commented Oct 19, 2017

I still reproduce this using atom-typescript package on the last version of atom (11.0.10).

@sangdth
Copy link

sangdth commented Oct 19, 2017

@lee-dohm I don't know why but since I disable/uninstall all eslint related and the problem was gone. I'm using 1.21.1 Atom.

@msukmanowsky
Copy link

I can still reproduce this with Atom 1.25.1 and language-babel (editing tab size for Babel ES6 JavaScript Grammar).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants