-
Notifications
You must be signed in to change notification settings - Fork 119
Fix positioning of placeholder with multiline tabs #215
Conversation
Also provided by https://atom.io/packages/multirow-tabs |
I've added this to the queue for review. Would you mind updating it to resolve the conflicts? |
9895927
to
db27fbb
Compare
Done! Twas a bit of work / complete rewrite, since y'all removed your use of jquery 😨 . Old version for ref: forivall@9895927 |
Looks like you have a failing spec related to your change @forivall. |
Sorry for the long delay. @50Wliu @lee-dohm updated. |
Can you show a before/after image @forivall? I'm not sure I understand what the "placeholder" you're referring to is. |
(These screenshots are using https://atom.io/packages/multirow-tabs |
/cc: @simurai |
A change in how flexbox works forced us to make the Should already be in the new Beta ( |
Closing this one since it is already fixed by #384. |
This fixes positioning of the placeholder in themes with multiline tabs (where I just updated mine to do this: https://atom.io/packages/adwaita-pro-ui)