Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix positioning of placeholder with multiline tabs #215

Closed
wants to merge 3 commits into from

Conversation

forivall
Copy link

This fixes positioning of the placeholder in themes with multiline tabs (where I just updated mine to do this: https://atom.io/packages/adwaita-pro-ui)

@forivall
Copy link
Author

Also provided by https://atom.io/packages/multirow-tabs

@lee-dohm lee-dohm added the atom label Mar 26, 2016
@lee-dohm
Copy link
Contributor

I've added this to the queue for review. Would you mind updating it to resolve the conflicts?

@forivall forivall force-pushed the multiline-tab-placeholder-fix branch from 9895927 to db27fbb Compare March 27, 2016 17:35
@forivall
Copy link
Author

Done! Twas a bit of work / complete rewrite, since y'all removed your use of jquery 😨 . Old version for ref: forivall@9895927

@winstliu
Copy link
Contributor

Looks like you have a failing spec related to your change @forivall.
https://travis-ci.org/atom/tabs/builds/118844936#L182

@forivall
Copy link
Author

forivall commented Oct 6, 2016

Sorry for the long delay. @50Wliu @lee-dohm updated.

@winstliu
Copy link
Contributor

winstliu commented Oct 6, 2016

Can you show a before/after image @forivall? I'm not sure I understand what the "placeholder" you're referring to is.

@forivall
Copy link
Author

forivall commented Oct 11, 2016

It's the blue thing.
Before:
atom-tabs-multiline-fix-before

After:
atom-tabs-multiline-fix-after

(These screenshots are using https://atom.io/packages/multirow-tabs
. My theme, which has multirow built-in, looks proper)

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Oct 11, 2016

/cc: @simurai

@simurai
Copy link
Contributor

simurai commented Oct 11, 2016

A change in how flexbox works forced us to make the .placeholder element be relatively positioned (PR #384). And I think as a side effect, it also fixed this issue.

tabs

Should already be in the new Beta (1.12) if somebody wants to try.

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Oct 18, 2016

Closing this one since it is already fixed by #384.

@Ben3eeE Ben3eeE closed this Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants