Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce log grid #221

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

timcallow
Copy link
Contributor

Ensures a log grid is used for Kubo-Greenwood and Gram-Schmidt calculations.

Issue #220 documents that we should extend the functionality of the sqrt grid.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (aa620fe) 96.55% compared to head (cca4b98) 97.12%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #221      +/-   ##
===========================================
+ Coverage    96.55%   97.12%   +0.57%     
===========================================
  Files           14       14              
  Lines         2407     2404       -3     
===========================================
+ Hits          2324     2335      +11     
+ Misses          83       69      -14     
Files Coverage Δ
atoMEC/postprocess/conductivity.py 97.72% <50.00%> (-0.32%) ⬇️
atoMEC/staticKS.py 98.60% <66.66%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timcallow timcallow merged commit 1ac1ec1 into atomec-project:develop Nov 8, 2023
5 of 6 checks passed
@timcallow timcallow deleted the enforce_log_grid branch November 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant