Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search index not properly updating initial data #560

Closed
joepio opened this issue Jan 19, 2023 · 0 comments
Closed

Search index not properly updating initial data #560

joepio opened this issue Jan 19, 2023 · 0 comments

Comments

@joepio
Copy link
Member

joepio commented Jan 19, 2023

Our E2E tests are failing on the search tests, namely checking the Welcome to your Atomic-Server search. This should be part of the initial index update, but for some reason isnt.

Some approaches:

  • Perhaps we should just add a 5 sec await, similar to the nested search query
  • Make sure that, on initialization, the search index is ran
  • Make sure that the changes made to Drives are commited, or passed through the mechanism that triggers update resources.

The add_all_resources function isn't called on initialize. We could simply call that, and that would fix the problem. But perhaps we need to ask ourselves: why isn't the search index properly updated? Either populate does not create Commits, or our Commits aren't caught by the CommitMonitor. I can see that .save_locally is used in most populate functions (including set_drive_rights, which sets the Welcome... text), so we are creating commits!

I suppose the Commit Monitor simply doesn't exist yet when we populate the store.

We could invert the order.

@joepio joepio closed this as completed Jan 19, 2023
joepio added a commit that referenced this issue Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant