Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor jumping to the end on seed confirm page #237

Closed
gcharang opened this issue May 19, 2018 · 1 comment
Closed

Cursor jumping to the end on seed confirm page #237

gcharang opened this issue May 19, 2018 · 1 comment
Labels
bug

Comments

@gcharang
Copy link

When creating a new portfolio, on the seed confirm page, after a few words are entered, if an attempt is made to edit the previous words (i.e., entering text in between the already entered words), after entering a single letter, the cursor jumps to the end of the line.
Demo

HyperDEX Nightly 0.0.0-536c5dd-18.5.18.1358
Electron 2.0.1
linux 4.13.0-41-generic
Locale: en-GB
@sindresorhus
Copy link
Contributor

Thanks for reporting. I'm working on a fix.

sindresorhus added a commit that referenced this issue May 24, 2018
@sindresorhus
Rewrite <Input> and <TextArea> components to be fully controlled
17682b8 
Since our state updates are async, it creates a race condition where React cannot correctly diff the updates and it results in the cursor being pushed to the end.

See this React issue: facebook/react#955 In short, just another React annoyance.

Fixes #237
@sindresorhus sindresorhus mentioned this issue May 24, 2018
Merged
sindresorhus added a commit that referenced this issue May 25, 2018
@sindresorhus
Rewrite <Input> and <TextArea> components to be fully controlled (#…
8ce7d6d 
…307)

Since our state updates are async, it creates a race condition where React cannot correctly diff the updates and it results in the cursor being pushed to the end.

See this React issue: facebook/react#955 In short, just another React annoyance.

Fixes #237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @gcharang